Mishandled expected error #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mishandled expected error
Description
A user recently reported that he didn't like the way dblab handles error happening at getting the metadata of a table. The way it works right now is that dblab crashes and prints out the error. The expected behavior is that every error generated by queries are printed on the
rows
view. So, I went ahead and made sure those errors are printed on the view mentioned above.Fixes #227
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unfortunately, the gui package doesn't have a test suite. To test this out, I hard-coded a non-existent table. This is supposed to error out due to the table is no present in the database.
Now, the expected error shows up on the
rows
table.Checklist: