Add completion support for bash|zsh|fish #52
Conversation
|
Thank you! Will take a look. |
Fixed |
|
@danielfoehrKn What do you think about embedding? There will be only one binary which would produce needed shell functions to source them. Final flow be like: |
| RESPONSE="$($EXECUTABLE_PATH "${opts[@]}")" | ||
| if [ $? -ne 0 -o -z "$RESPONSE" ] |
There was a problem hiding this comment.
I would have to check if all commands still work. But if it does it is a really nice refactoring
I am not quite sure how that is different from your current approach . You could still use the switcher binary to generate the bash|fish|zsh completions and source them. Maybe I am misunderstanding something. |
Now kubeswitch contains binary switcher, switch.sh script and switch.fish script. So to completely activate My idea is to generate internals of switch.sh script by I mean scripts |
|
|
||
| return ns.SwitchNamespace(getKubeconfigPathFromFlag(), stateDirectory, noIndex) | ||
| }, | ||
| SilenceErrors: true, |
There was a problem hiding this comment.
Need to implement ValidArgs function for autocompletion
| reportNewContext(kc) | ||
| return err | ||
| }, | ||
| SilenceUsage: true, |
There was a problem hiding this comment.
Need to implement ValidArgs function for autocompletion
| return err | ||
| } | ||
| return delete_context.DeleteContext(ctxName) | ||
| }, |
There was a problem hiding this comment.
Need to implement ValidArgs function for autocompletion
|
|
||
| return alias.RemoveAlias(args[0], stateDirectory) | ||
| }, | ||
| SilenceErrors: true, |
There was a problem hiding this comment.
Need to implement ValidArgs function for autocompletion
|
@avlllo any chance you can continue this great work? 🙏 |
Completions were rewritten to make it possible to have completions for all shells.
cmd/switcher/switcher.gowas split into subcommandsswitch completionwas introduced incmd/switcher/completion.golist-contexts,delete-context,unset-contextandcurrent-contextwere implemented to make shell script as small as possible-u|-d|-cwere moved from shell into binaryNote: fish shell has built-in command
switchsokubeswitchwas used for fishFixes #42, fixes #46