-
Notifications
You must be signed in to change notification settings - Fork 105
use v2025.5.1 branch #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use v2025.5.1 branch #201
Conversation
Not much to look at here now haha. But, we can already add the specific 2025.5.1 changes to Vaultwarden css though. You can use an if-else (webver >= 2025.5.1) for this. Also because maybe some users have an out-of-sync Vaultwarden<>Web-vault. |
Just tested it and it doesn't work with my local version because the web-vault version in bw_web_builds/scripts/build_web_vault.sh Lines 31 to 33 in a84aca5
Manually changing it to |
Shouldn't this have created a new release or did I misunderstand the process. |
Only when i actually create it. For which i didn't had time to fully start it. |
What does that mean? Create what exactly? A tag? Or the github form at |
Yes a tag indeed. bw_web_builds/.github/workflows/release.yml Lines 3 to 6 in f5dbf83
|
Thanks and sorry for my questions. I just wanted to understand the process because your second part "For which i didn't had time to fully start it." made me wonder. |
Well, i was working on other stuff. And merged this during a coffee break at my day job, and after that lost in other stuff. I'm a bit chaotic and multi-tasking all day long. |
No, no. Please don't take this the wrong way. I understand that you are busy. I just wanted to understand the process. It'll be ready, when it's ready. P.S.: I can build everyhing myself. I am not in need of official releases. |
Update to use new web-vault. Also added new css classes for the or text and login with passkey button and sso login button on the login page, cf. vaultwarden/vw_web_builds@045b0cf
So we can hide those elements explicitly and more reliably as suggested in dani-garcia/vaultwarden#5890. (Once we update the web-vault to
v2025.5.1
we can change the selectors to.vw-sso-login
,.vw-passkey-login
and.vw-or-text
respectively.)