Skip to content

use v2025.5.1 branch #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Conversation

stefan0xC
Copy link
Contributor

Update to use new web-vault. Also added new css classes for the or text and login with passkey button and sso login button on the login page, cf. vaultwarden/vw_web_builds@045b0cf
So we can hide those elements explicitly and more reliably as suggested in dani-garcia/vaultwarden#5890. (Once we update the web-vault to v2025.5.1 we can change the selectors to .vw-sso-login, .vw-passkey-login and .vw-or-text respectively.)

@BlackDex
Copy link
Collaborator

Not much to look at here now haha.

But, we can already add the specific 2025.5.1 changes to Vaultwarden css though. You can use an if-else (webver >= 2025.5.1) for this. Also because maybe some users have an out-of-sync Vaultwarden<>Web-vault.

@stefan0xC
Copy link
Contributor Author

stefan0xC commented May 29, 2025

But, we can already add the specific 2025.5.1 changes to Vaultwarden css though. You can use an if-else (webver >= 2025.5.1) for this.

Just tested it and it doesn't work with my local version because the web-vault version in vw-version.json which is used to determine the version first is still v2025.5.0.

printf '{"version":"%s"}' \
"$(git -c 'versionsort.suffix=-' ls-remote --tags --refs --sort='v:refname' https://github.com/dani-garcia/bw_web_builds.git 'v*' | tail -n1 | grep -Eo '[^\/v]*$')" \
> build/vw-version.json

Manually changing it to v2025.5.1 works.

@BlackDex BlackDex merged commit f5dbf83 into dani-garcia:master Jun 4, 2025
1 check passed
@stefan0xC stefan0xC deleted the update-to-v2025.5.1 branch June 4, 2025 12:34
@tessus
Copy link
Contributor

tessus commented Jun 4, 2025

Shouldn't this have created a new release or did I misunderstand the process.

@BlackDex
Copy link
Collaborator

BlackDex commented Jun 4, 2025

Only when i actually create it. For which i didn't had time to fully start it.

@tessus
Copy link
Contributor

tessus commented Jun 4, 2025

Only when i actually create it

What does that mean? Create what exactly? A tag? Or the github form at https://github.com/dani-garcia/bw_web_builds/releases/new?

@BlackDex
Copy link
Collaborator

BlackDex commented Jun 4, 2025

Yes a tag indeed.

on:
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+[a-z]?'

@tessus
Copy link
Contributor

tessus commented Jun 4, 2025

Thanks and sorry for my questions. I just wanted to understand the process because your second part "For which i didn't had time to fully start it." made me wonder.
Creating a tag takes 3 seconds and pushing the tag another second. Of course "drafting" a release via the github form takes more time, if you do it manually (creating the changelog, the release text, ...).
Even though I am not a project member I still like to understand the inner workings of a project, especially one I am very much interested in.

@BlackDex
Copy link
Collaborator

BlackDex commented Jun 4, 2025

Well, i was working on other stuff. And merged this during a coffee break at my day job, and after that lost in other stuff. I'm a bit chaotic and multi-tasking all day long.

@tessus
Copy link
Contributor

tessus commented Jun 4, 2025

No, no. Please don't take this the wrong way. I understand that you are busy. I just wanted to understand the process. It'll be ready, when it's ready.

P.S.: I can build everyhing myself. I am not in need of official releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants