Skip to content

Update kmeans inputs #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2025
Merged

Update kmeans inputs #1752

merged 4 commits into from
Aug 12, 2025

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Aug 12, 2025 •
edited by k034b363
Loading

Describe your changes
Updates predict_kmeans to input a ndarray directly instead of reading from a file. Removes a circular import.

Type of update
Is this a: minor update

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.9 milestone Aug 12, 2025
@nfahlgren nfahlgren added enhancement Enhancements to existing features ready to review labels Aug 12, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Aug 12, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Aug 12, 2025 •
edited
Loading

Here's the code health analysis summary for commits 0d6135f..dea66cc. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren requested a review from k034b363 August 12, 2025 02:10
k034b363
k034b363 approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested on one of the seed xray images and it works fine. I think this is technically a breaking change, so I don't know how that affects when to merge it, but I'll approve it anyway so it's ready whenever.

@nfahlgren nfahlgren merged commit 6969194 into main Aug 12, 2025
5 checks passed
@nfahlgren nfahlgren deleted the update-kmeans-inputs branch August 12, 2025 16:41
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Aug 12, 2025
This was referenced Aug 15, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k034b363 k034b363 k034b363 approved these changes

Assignees
No one assigned
Labels
enhancement Enhancements to existing features ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.9
Development

Successfully merging this pull request may close these issues.
2 participants
@nfahlgren @k034b363