Skip to content

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Aug 12, 2025

Describe your changes
Some time ago when we updated the default settings in WorkflowConfig, it caused one line of code in job_builder to become uncovered by tests. This PR updates a job_builder test to cover the missing line.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.9 milestone Aug 12, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Aug 12, 2025
Copy link

deepsource-io bot commented Aug 12, 2025

Here's the code health analysis summary for commits 2769c43..74c12f3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl self-requested a review August 12, 2025 14:52
@nfahlgren nfahlgren merged commit 0d6135f into main Aug 12, 2025
5 checks passed
@nfahlgren nfahlgren deleted the fix-coverage-jobbuilder branch August 12, 2025 16:09
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants