Skip to content

Conversation

joshqsumner
Copy link
Contributor

@joshqsumner joshqsumner commented Jul 22, 2025

Describe your changes
Moving dilate to a helper function to help with circular import problems

Type of update
This is code cleanup

Associated issues
No directly associated issues, sort of #1674 since I ran into the import problem working on that.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Jul 22, 2025

Here's the code health analysis summary for commits 410a6f1..1fd0452. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@joshqsumner joshqsumner requested a review from nfahlgren July 22, 2025 17:55
@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Jul 22, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Jul 22, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.9 milestone Jul 22, 2025
@nfahlgren nfahlgren merged commit 9311617 into main Jul 23, 2025
5 checks passed
@nfahlgren nfahlgren deleted the dilation-helper branch July 23, 2025 01:28
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants