Add color card detection squareness parameters #1732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
plus removed some code that i don't think we need, and bring some stuff upstream of the algo split to slightly reduce repetition
add color option to the _draw_color_chips helper function
and auto_correct_color.md
joshqsumner
requested changes
Aug 5, 2025
There was a problem hiding this comment.
My only concern would be whether we should define aspect ratio/solidity for this context someplace in the docs. Change could be as simple as this on lines 19 and 20 of docs/transform_detect_color_card.md or we could do something prettier. Code wise I'd approve the change as is but could see this being helpful particularly with aspect ratio conventionally defined as width/height when what we're doing has a lower bound of 1 since we take max axis / min axis.
Edit: We could also have an if statement that takes the reciprocal of aspect_ratio if it is <1 which would help some too I think.
- aspect_ratio - Optional aspect ratio (longest side / shortest side) below which objects will get removed (default = 1.27)
- solidity - Optional solidity (area / convex hull area) filter (default = 0.8)
also define calculation of new parameters in doc page
joshqsumner
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add optional kwargs to allow users to modify the
solidityandaspect_ratiofilters, implemented inpcv.transform.detect_color_cardand withinpcv.transform.auto_correct_color, which keeps the detected edges that are square-like. Loosening this parameters from their previously hard-coded defaults might help with color card detection in cases where the image is skewed.Also, adds verbose debug images of detected edges in the case where detection fails to find a color card under default settings. This aims to help debug the keyword argument settings.
Type of update
Is this a:
Associated issues
Additional context
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md