Skip to content

Quiet print statements from pcv.homology.acute #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2025
Merged

Quiet print statements from pcv.homology.acute #1730

merged 8 commits into from
Jul 29, 2025

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
Update within pcv.homology.acute to turn off print statements with pcv.params.verbose, rather than controlling the print statements by changing debug mode to None. With these proposed changes, a user can create a debugging image without necessarily printing out many lines of statements.

Type of update
Is this a:

  • code cleanup

Associated issues

Additional context
It seems like there's mention of a verbose text file, which I think it aims to capture the print statements in a text file rather than printing to the screen. Not implemented currently; it's unclear to me how these print statements help with debugging but I would be happy to make the verbose text file work if someone would find it helpful.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added this to the PlantCV v4.9 milestone Jul 14, 2025
@HaleySchuhl HaleySchuhl self-assigned this Jul 14, 2025
@HaleySchuhl HaleySchuhl added the cleanup Code quality updates label Jul 14, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Jul 14, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jul 14, 2025 •
edited
Loading

Here's the code health analysis summary for commits cf3a7df..cdad419. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

nfahlgren
nfahlgren requested changes Jul 17, 2025
View reviewed changes
Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_dist is removed as an output but it should remain an output. Despite the docstring, verbose_out has not been an output

@HaleySchuhl HaleySchuhl requested a review from nfahlgren July 17, 2025 16:12
@nfahlgren
Copy link
Member

Was max_dist renamed max_chain for a reason?

@HaleySchuhl
Copy link
Contributor Author

Was max_dist renamed max_chain for a reason?

Nope, that's just me getting confused because I saw the other output called chain. I'll fix that now.

@nfahlgren nfahlgren merged commit 5f38a5c into main Jul 29, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Jul 29, 2025
@nfahlgren nfahlgren deleted the add-verbose-setting-to-acute branch July 29, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfahlgren nfahlgren nfahlgren approved these changes

Assignees

@nfahlgren nfahlgren

@HaleySchuhl HaleySchuhl

Labels
cleanup Code quality updates ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.9
Development

Successfully merging this pull request may close these issues.

Quiet print statements in pcv.homology.acute
2 participants
@HaleySchuhl @nfahlgren