Report size marker warning message #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
nfahlgren
previously requested changes
Jul 17, 2025
There was a problem hiding this comment.
Here we only return the area of the size marker. I think removing the fitted ellipse makes sense since that is best for a circular size marker, but the new documentation suggests you can set the pixel height and width by taking the square root of the area. That works for a rectangular marker but is not the height and width of a circle or other polygon. Instead, could we include the observed height and width of the marker in addition to the area?
After discussion the PR is good to go without these changes
HaleySchuhl
approved these changes
Jul 21, 2025
No longer used since results are stored in metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.
Changes report_size_marker to output as metadata instead of observations and to fail gracefully if size marker is not detected.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
closes #1638
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md