Rotate transformation is not applied about the center of an image
#1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
nfahlgren
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
rotatefunction finds the center of rotation as half the length and width of an image. This is offset from the actual center by half a pixel, and in some specific use-cases can significantly reduce the average color value of a rotated region. This PR updatesrotateto account for the half-pixel offset to re-center rotation transformations.Type of update
This is a:
Associated issues
None
Additional context
An example figure illustrating the effect of off-center rotation and 0 values being inserted, as well as the behavior with this bugfix, is shown here:
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md