Skip to content

Add global size parameters to Params class #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2025
Merged

Add global size parameters to Params class #1712

merged 3 commits into from
Jun 2, 2025

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented May 30, 2025 •
edited by k034b363
Loading

Describe your changes
Add global size parameters (unit px_width and px_height) to Params class to prepare for functionality support to do size scaling directly during analysis steps. Also update documentation page to include the new parameters.

Associated issues

Additional context
Next steps: PR2: use units/px factors in analyze functions; PR3: sets global params given color card chip sizes

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added this to the PlantCV v4.8 milestone May 30, 2025
@HaleySchuhl HaleySchuhl self-assigned this May 30, 2025
@HaleySchuhl HaleySchuhl added the new feature New feature ideas and solutions label May 30, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 May 30, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented May 30, 2025 •
edited
Loading

Here's the code health analysis summary for commits ff26d6d..e4a5c58. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363
Update classes.py
644ecbc 
Fix typo in doctoring
k034b363
k034b363 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked docs and made sure the new params show up as expected in a notebook. Looks good to me!

@nfahlgren nfahlgren merged commit 1631cb6 into main Jun 2, 2025
5 checks passed
@nfahlgren nfahlgren deleted the add-global-size-parameters branch June 2, 2025 21:33
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k034b363 k034b363 k034b363 approved these changes

Assignees

@HaleySchuhl HaleySchuhl

Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@HaleySchuhl @k034b363 @nfahlgren