Update array stacking for color standard processing #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
|
Here's the code health analysis summary for commits Analysis Summary
|
|
@nfahlgren looks like the DeepSource is failing to not-related changes in same file |
|
@emmanuel-ferdman, for sure. I'm looking at them to see if they are easy/worth fixing. One was a false positive, the comment just happened to look like code. The unbalanced tuple unpacking errors I'm not sure about, I might just ignore them and merge. Thanks for your help! |
nfahlgren
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR modernizes NumPy array stacking in the color chip data preparation pipeline by replacing deprecated aliases.
It solves the following warnings which you can find in the CI logs:
It also fixes a few typos along the way.
Type of update
Is this a:
Associated issues
Additional context
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md