Skip to content

Fix colors in visualize.colorize_masks #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Fix colors in visualize.colorize_masks #1702

merged 1 commit into from
May 13, 2025

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented May 12, 2025 •
edited by nfahlgren
Loading

Describe your changes
A couple of the named colors available in visualize.colorize_masks had color values that differed from what was listed on the linked web page. This PR fixes those values.

Type of update
Is this a:

  • Bug fix

Associated issues
Closes #1701

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 linked an issue May 12, 2025 that may be closed by this pull request
Some color values are incorrect for visualize.colorize_masks #1701
Closed
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented May 12, 2025 •
edited
Loading

Here's the code health analysis summary for commits 84c8e2b..53a6bce. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren self-requested a review May 13, 2025 15:35
@nfahlgren nfahlgren added this to the PlantCV v4.8 milestone May 13, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 May 13, 2025
@nfahlgren nfahlgren self-assigned this May 13, 2025
@nfahlgren nfahlgren merged commit 88c5618 into main May 13, 2025
5 checks passed
@nfahlgren nfahlgren deleted the 1701-wrong-colors branch May 13, 2025 15:38
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfahlgren nfahlgren nfahlgren approved these changes

Assignees

@nfahlgren nfahlgren

Labels
bugfix Bug fixes ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.8
Development

Successfully merging this pull request may close these issues.

Some color values are incorrect for visualize.colorize_masks
2 participants
@k034b363 @nfahlgren