Skip to content

adding nd2 as a image read mode #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

adding nd2 as a image read mode #1695

merged 4 commits into from
Jun 4, 2025

Conversation

annacasto
Copy link
Contributor

@annacasto annacasto commented May 5, 2025 •
edited by k034b363
Loading

Describe your changes
Added "nd2" as a readimage mode to read in Nikon microscope images.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
#1684

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@annacasto annacasto added new feature New feature ideas and solutions work in progress Mark work in progress labels May 5, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented May 5, 2025 •
edited
Loading

Here's the code health analysis summary for commits 1631cb6..7b38833. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@annacasto annacasto self-assigned this Jun 2, 2025
@annacasto annacasto added ready to review and removed work in progress Mark work in progress labels Jun 2, 2025
@annacasto annacasto requested a review from k034b363 June 3, 2025 15:12
k034b363
k034b363 approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Works just fine in a notebook after separately installing nd2.

@annacasto
Copy link
Contributor Author

Hmm, I added nd2 as a new dependency, but maybe if you didn't re-install in a new environment, nd2 wouldn't have installed? I guess the tests pass and the builds don't fail so maybe that's fine?

@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Jun 4, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.8 milestone Jun 4, 2025
@nfahlgren
Copy link
Member

New dependencies only get installed automatically if you create a new condo environment or run the pip install command. If you install from source in editable mode so that you don't have to rerun pip, then it won't install automatically

@nfahlgren nfahlgren merged commit 654a45b into main Jun 4, 2025
5 checks passed
@nfahlgren nfahlgren deleted the read-in-nd2-files branch June 4, 2025 16:35
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Jun 4, 2025
@HaleySchuhl HaleySchuhl mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k034b363 k034b363 k034b363 approved these changes

Assignees

@annacasto annacasto

Labels
new feature New feature ideas and solutions ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@annacasto @nfahlgren @k034b363