Skip to content

Add check to train kmeans that inputs must be np arrays #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 2, 2025
Merged

Add check to train kmeans that inputs must be np arrays #1683

merged 5 commits into from
May 2, 2025

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented Mar 10, 2025 •
edited by HaleySchuhl
Loading

Describe your changes
Adds a check to train.kmeans that the inputs must be numpy arrays. This fixes a problem that arises if intermediate or hidden files get added to image directories.

Type of update
Is this a:

  • Bug fix

Associated issues
Closes #1682

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 linked an issue Mar 10, 2025 that may be closed by this pull request
Kmeans training step should check for numpy arrays #1682
Closed
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Mar 10, 2025 •
edited
Loading

Here's the code health analysis summary for commits 438ee39..72519d1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added bugfix Bug fixes work in progress Mark work in progress labels Mar 10, 2025
@k034b363 k034b363 added this to the PlantCV v4.x milestone Mar 10, 2025
@k034b363 k034b363 self-assigned this Mar 10, 2025
@k034b363 k034b363 added ready to review and removed work in progress Mark work in progress labels Mar 11, 2025
@HaleySchuhl HaleySchuhl self-requested a review April 1, 2025 14:38
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 May 2, 2025
@nfahlgren nfahlgren modified the milestones: PlantCV v4.x, PlantCV v4.8 May 2, 2025
@nfahlgren nfahlgren merged commit 6eebf6a into main May 2, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 May 2, 2025
@nfahlgren nfahlgren deleted the 1682-train-kmeans-check-arrays branch May 2, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

Assignees

@k034b363 k034b363

Labels
bugfix Bug fixes ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.8
Development

Successfully merging this pull request may close these issues.

Kmeans training step should check for numpy arrays
3 participants
@k034b363 @HaleySchuhl @nfahlgren