Skip to content

Update pinnings to NumPy v2 #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

Update pinnings to NumPy v2 #1687

merged 5 commits into from
Apr 1, 2025

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Mar 30, 2025 •
edited by HaleySchuhl
Loading

Describe your changes
Updates requirements to require NumPy 2. Fixes a minor issue in texture that was no longer compatible with NumPy2.

Type of update
Is this a: bugfix with Colab

Closes #1686

After review and merging, release PlantCV v4.7

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added enhancement Enhancements to existing features work in progress Mark work in progress labels Mar 30, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.7 milestone Mar 30, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Mar 30, 2025
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Mar 30, 2025 •
edited
Loading

Here's the code health analysis summary for commits f31423c..8747499. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren added ready to review and removed work in progress Mark work in progress labels Mar 30, 2025
@nfahlgren nfahlgren mentioned this pull request Mar 30, 2025
Closed
@nfahlgren nfahlgren changed the title Test updating to NumPy 2 Update pinnings to NumPy v2 Mar 30, 2025
@nfahlgren nfahlgren added the bugfix Bug fixes label Mar 30, 2025
@nfahlgren nfahlgren requested a review from HaleySchuhl March 30, 2025 20:00
@nfahlgren nfahlgren merged commit 00b8b36 into main Apr 1, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Apr 1, 2025
@nfahlgren nfahlgren deleted the unpin-numpy branch April 1, 2025 21:49
@rayn-alex
Copy link
Collaborator

@nfahlgren
Quick question: We were running into problems with matplotlib>numpy on macOS using plantCV v4.6.
These errors (fatal python BUS error while writing an image with plantcv.print_image()) were solved with a numpy upgrade (v1.6>v2.x)

From what I could see, there was nothing critical that depended on numpy v1.6 and needed to be changed, right?

@nfahlgren
Copy link
Member Author

There is a syntax issue in calc_texture with numpy 2 (you just have to remove a=). That probably doesn't affect anything you are using, but tests would fail. Other than that I didn't have to change anything else and even that change is backwards compatible.

@rayn-alex
Copy link
Collaborator

Yes, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

Assignees
No one assigned
Labels
bugfix Bug fixes enhancement Enhancements to existing features ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.7
Development

Successfully merging this pull request may close these issues.

Trouble with install/import in colab
3 participants
@nfahlgren @rayn-alex @HaleySchuhl