Skip to content

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Feb 14, 2025

Describe your changes
add metadata attribute (a relatively new attribute for Spectral_data class instances. This change is inside _package_index in spectral_index.py

Type of update
Is this a:

  • Bug fix
  • feature enhancement

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added bugfix Bug fixes ready to review update Updates an existing feature/method labels Feb 14, 2025
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.7 milestone Feb 14, 2025
@HaleySchuhl HaleySchuhl self-assigned this Feb 14, 2025
Copy link

deepsource-io bot commented Feb 14, 2025

Here's the code health analysis summary for commits d2109bb..7a07875. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

replace with updated Spectral_data so that it includes metadata attribute
@nfahlgren nfahlgren merged commit d874246 into main Mar 14, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Mar 14, 2025
@nfahlgren nfahlgren deleted the add_metadata_to_spectral_indices branch March 14, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes ready to review update Updates an existing feature/method
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

metadata attribute is missing in calculated spectral indices
2 participants