Skip to content

adding json2csv to run-workflow #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

adding json2csv to run-workflow #1658

merged 2 commits into from
Jan 24, 2025

Conversation

joshqsumner
Copy link
Contributor

@joshqsumner joshqsumner commented Jan 21, 2025 •
edited by HaleySchuhl
Loading

Describe your changes
Added json2csv to run-workflow to make csv files by default from the output json.

Type of update
Is this a new feature or feature enhancement.

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Note that I do not have a good dataset to test on locally so this is untested at time of opening PR.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner requested a review from nfahlgren January 21, 2025 20:34
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jan 21, 2025 •
edited
Loading

Here's the code health analysis summary for commits c6105a7..9c5b6a2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

HaleySchuhl
HaleySchuhl requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just suggested a minor change to the last print statement that got added.

@HaleySchuhl HaleySchuhl added the enhancement Enhancements to existing features label Jan 22, 2025
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.7 milestone Jan 22, 2025
@HaleySchuhl HaleySchuhl self-requested a review January 23, 2025 21:56
HaleySchuhl
HaleySchuhl approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nfahlgren nfahlgren merged commit add740e into main Jan 24, 2025
5 checks passed
@nfahlgren nfahlgren deleted the json2csv_by_default branch January 24, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

@nfahlgren nfahlgren Awaiting requested review from nfahlgren

Assignees
No one assigned
Labels
enhancement Enhancements to existing features
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@joshqsumner @HaleySchuhl @nfahlgren