Skip to content

changing parallelization defaults #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 24, 2025
Merged

changing parallelization defaults #1654

merged 6 commits into from
Jan 24, 2025

Conversation

joshqsumner
Copy link
Contributor

Describe your changes
Changes to default settings in plantcv/plantcv/parallel/__init__.py based on issue #1639

Type of update
Is this a feature enhancement based on common parallelization questions.

Associated issues
Closes #1639

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner requested a review from nfahlgren January 21, 2025 16:16
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jan 21, 2025 •
edited
Loading

Here's the code health analysis summary for commits 53c783b..03d2fb2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl self-requested a review January 24, 2025 16:41
@nfahlgren nfahlgren added the enhancement Enhancements to existing features label Jan 24, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.7 milestone Jan 24, 2025
HaleySchuhl
HaleySchuhl approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this branch to make a template config file and looks good to me. I updated one more doc page to reflect the new defaults.

@nfahlgren nfahlgren merged commit 26f8986 into main Jan 24, 2025
5 checks passed
@nfahlgren nfahlgren deleted the parallelization_defaults branch January 24, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

@nfahlgren nfahlgren Awaiting requested review from nfahlgren

Assignees
No one assigned
Labels
enhancement Enhancements to existing features ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.7
Development

Successfully merging this pull request may close these issues.

Update parallel configuration defaults: append and tmp_dir
3 participants
@joshqsumner @HaleySchuhl @nfahlgren