Skip to content

Conversation

rayn-alex
Copy link
Collaborator

@rayn-alex rayn-alex commented Aug 28, 2024

Describe your changes
Added checks in _roi_filter() and analyze.spectral_index()

Type of update
Is this a:

  • Bug fix

Associated issues
Closes #1588

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Aug 28, 2024

Here's the code health analysis summary for commits 7ff2e57..7495c39. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl self-requested a review August 29, 2024 20:44
@HaleySchuhl HaleySchuhl added bugfix Bug fixes update Updates an existing feature/method labels Aug 29, 2024
Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking the time to code this bugfix. I changed the if else logic a little bit to simplify.

@nfahlgren nfahlgren merged commit 26bfd9a into danforthcenter:main Sep 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes ready to review update Updates an existing feature/method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis fails if one ROI is empty
3 participants