-
Notifications
You must be signed in to change notification settings - Fork 271
Add kmeans cli #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add kmeans cli #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
I think I'm not going to add the command line option to the kmeans tutorial for now. I think that it maybe belongs in a separate tutorial about model choice more generally? |
nfahlgren
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
It has been suggested that for some model choice situations, it would be helpful to run kmeans training from the command line, similarly to how naive bayes training can work. This PR adds kmeans training to the command line interface file.
To test, reviewer can use something like the following from the command line:
plantcv-train kmeans -i IMGDIR -k 3 -o OUTDIR/kmeans_cli_out.fit -r kmeans_train -p 2
with "IMGDIR" containing the four training images currently in testdata/kmeans_train_dir
Type of update
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md