Add quality control for image color #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
Update based on python auto code checks for style
Fixed indentation
Add the option to change the warning threshold
Update style
style updates
|
@kmurphy61 I will continue to work on this today! I believe we want the output observation to be a metadata term since it's an image-level metric. I'll plan to ping you on slack when it's ready for you to test locally, and we can divide up the remaining PR tasks to get this ready to review 💫 |
image level metric rather than object level
…ter/plantcv into 1573-quality-control
add print, parameterize it, and update read to cv2 function so only one pcv function file is getting tested
…ter/plantcv into 1573-quality-control
nfahlgren
approved these changes
Aug 15, 2024
No need to test different debug modes since the debug logic now uses _debug Float equality is not a stable test, use np.isclose instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A new function that allows a user to view the R, G, and B histograms to determine if they are too close to the minimum (0) or maximum (255), which would suggest the image is over or underexposed. 5% is used as the cutoff for a warning message.
Type of update
Associated issues
Issue #1573
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md