Skip to content

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Jul 5, 2024

Describe your changes
In NumPy 1.25, casting single value arrays to Python data types is deprecated. In general this PR extracts the single value before casting to fix the issue (or avoids casting when unnecessary).

Type of update
Is this a: cleanup

Associated issues
#1566

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Jul 5, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.4 milestone Jul 5, 2024
Copy link

deepsource-io bot commented Jul 5, 2024

Here's the code health analysis summary for commits 76cd4a1..e49f15d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren mentioned this pull request Jul 5, 2024
@nfahlgren nfahlgren merged commit a663b14 into main Jul 9, 2024
@nfahlgren nfahlgren deleted the numpy-dep-cast-single-vals branch July 9, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants