Skip to content

Removed unnecessary comprehension #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2025
Merged

Removed unnecessary comprehension #1558

merged 3 commits into from
Apr 5, 2025

Conversation

kaitlynrying
Copy link
Collaborator

Describe your changes
Removed unnecessary list comprehension in lines 132 and 149 in hyper_histogram.py

Type of update
This is a

  • Bug fix

Associated issues
Related to Deepsource PTC-W0016

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jul 1, 2024 •
edited
Loading

Here's the code health analysis summary for commits 00b8b36..afc856a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 2 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

zeeuqsze
zeeuqsze approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@zeeuqsze zeeuqsze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! That is more memory efficient.

@nfahlgren nfahlgren added the cleanup Code quality updates label Apr 5, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Apr 5, 2025
@nfahlgren nfahlgren added this to the PlantCV v4.7 milestone Apr 5, 2025
@nfahlgren nfahlgren merged commit 438ee39 into danforthcenter:main Apr 5, 2025
4 of 5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeuqsze zeeuqsze zeeuqsze approved these changes

Assignees
No one assigned
Labels
cleanup Code quality updates
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlynrying @zeeuqsze @nfahlgren