1553-combined-object-filter #1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
|
Sample image and notebook for testing in data_science drive in jupyter/filter_objs |
Since filters is the name of the submodule filter doesn't need to be in the name of the function too?
|
@k034b363 is the updated function name okay? I figure since it is in the |
We still support Python 3.9, which doesn't have all the type hinting features that were added in 3.10
nfahlgren
approved these changes
Jul 5, 2024
Yep, that makes sense! I didn't choose the name with any reasoning or logic, I like the change better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Taking the logic of existing filter on eccentricity, this function expands to allow filtering on any numeric (float or int) object property calculated by
skimage.measure.regionprops. The default threshold is 0 andcut_side="upper", which will filter nothing for most (but not all) properties. Users can also specify keeping objects below the given threshold by settingcut_sideto "lower".Type of update
Is this a:
Associated issues
This closes #1553
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md