Skip to content

Conversation

natejly
Copy link
Collaborator

@natejly natejly commented May 28, 2024

Related to deepsource PTC-W0068
Using for loops to manually iterate to avoid using equality comparisons with None
Also separated code into some helper functions to reduce complexity

@natejly natejly self-assigned this May 28, 2024
Copy link

deepsource-io bot commented May 28, 2024

Here's the code health analysis summary for commits 7382467..764d3ab. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 6 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@natejly natejly added the work in progress Mark work in progress label May 28, 2024
@natejly natejly changed the title Fixing incorrect use of operators when comparing to None Constella reworks May 29, 2024
@natejly natejly added ready to review cleanup Code quality updates and removed work in progress Mark work in progress labels May 29, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.4 milestone Jul 5, 2024
@nfahlgren nfahlgren merged commit 0032a39 into main Jul 5, 2024
@nfahlgren nfahlgren deleted the PTC-W0068 branch July 5, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants