Skip to content

Conversation

HaleySchuhl
Copy link
Contributor

Describe your changes
update _make_pseudo_rgb with more accurate target wavelength for red. Previously, a target wavelength of 710nm for red was causing the code to grab the Red Edge band rather than the band the camera manufacturer calls red.

Type of update
Is this a:

  • Bug fix
  • New feature or feature enhancement
  • Update to documentation
  • Work in progress

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added bugfix Bug fixes update Updates an existing feature/method labels Apr 12, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.3 milestone Apr 12, 2024
@HaleySchuhl HaleySchuhl self-assigned this Apr 12, 2024
Copy link

deepsource-io bot commented Apr 12, 2024

Here's the code health analysis summary for commits c382d06..0f52520. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren merged commit a745b53 into main Apr 17, 2024
@nfahlgren nfahlgren deleted the update_target_channel_pseudo_rgb branch April 17, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes ready to review update Updates an existing feature/method
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants