Skip to content

Bump supported versions of Python to 3.9-3.11 #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 16, 2024
Merged

Bump supported versions of Python to 3.9-3.11 #1491

merged 19 commits into from
Apr 16, 2024

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Apr 12, 2024 •
edited
Loading

Describe your changes
Modifies GitHub Actions workflows, conda environment template, and installation instructions to bump the supported versions of Python to 3.9, 3.10, and 3.11.

This PR also replaces automated versioning with versioneer to setuptools-scm.

Type of update
Is this a: New feature or feature enhancement

Associated issues
#1490

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added testing Features related to testing and deployment ready to review update Updates an existing feature/method labels Apr 12, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 12, 2024
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Apr 12, 2024 •
edited
Loading

Here's the code health analysis summary for commits 3964d6a..5b28a70. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 4 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7% (up 5.6% from main)99.7% (up 5.6% from main)
Line Coverage99.7% (up 5.6% from main)99.7% (up 5.6% from main)
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl
Copy link
Contributor

Seems like 3.12 has a difference when it comes to distutils but people claim that installing setuptools is a good workaround.

@nfahlgren nfahlgren changed the title Bump supported versions of Python to 3.10-3.12 Bump supported versions of Python to 3.9-3.11 Apr 16, 2024
@nfahlgren nfahlgren requested a review from HaleySchuhl April 16, 2024 01:41
@nfahlgren nfahlgren merged commit 0fa2b31 into main Apr 16, 2024
@nfahlgren nfahlgren deleted the bump-python-versions branch April 16, 2024 16:37
@HaleySchuhl HaleySchuhl mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

Assignees
No one assigned
Labels
ready to review testing Features related to testing and deployment update Updates an existing feature/method
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nfahlgren @HaleySchuhl