Skip to content

Remove deprecated files #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2024
Merged

Remove deprecated files #1499

merged 2 commits into from
Apr 22, 2024

Conversation

nfahlgren
Copy link
Member

Describe your changes
Removes mask images from PlantCV v1 and installation script files from PlantCV v2

Type of update
Is this a: cleanup

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added ready to review cleanup Code quality updates labels Apr 20, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 20, 2024
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Apr 20, 2024 •
edited
Loading

Here's the code health analysis summary for commits e93d63a..0f61f5b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl self-requested a review April 22, 2024 15:10
@nfahlgren nfahlgren merged commit e1eb6d8 into main Apr 22, 2024
@nfahlgren nfahlgren deleted the remove-deprecated-files branch April 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

Assignees
No one assigned
Labels
cleanup Code quality updates ready to review
Projects
PlantCV4
Status: Done
Milestone
PlantCV v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nfahlgren @HaleySchuhl