Skip to content

fix-PYL-W0612 #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix-PYL-W0612 #1497

merged 2 commits into from
Apr 19, 2024

Conversation

k034b363
Copy link
Contributor

Describe your changes
Fixed deepsource unused variable issues. Changed 6 instances of unused variable name assignments to "_" across 4 files.

Type of update
Deepsource issue fix

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 added work in progress Mark work in progress cleanup Code quality updates labels Apr 18, 2024
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Apr 18, 2024 •
edited
Loading

Here's the code health analysis summary for commits c858f62..1ce8a33. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 6 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added ready to review and removed work in progress Mark work in progress labels Apr 18, 2024
@nfahlgren nfahlgren merged commit 7103e06 into main Apr 19, 2024
@nfahlgren nfahlgren deleted the fix-PYL-W0612 branch April 19, 2024 20:52
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

Assignees
No one assigned
Labels
cleanup Code quality updates ready to review
Projects
PlantCV4
Status: Pull Requests
Milestone
PlantCV v4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@k034b363 @HaleySchuhl @nfahlgren