Skip to content

Conversation

nfahlgren
Copy link
Member

Describe your changes
We recently added a new feature that cross imported from the learn submodule, which contains code that checks the environment and sets matplotlib to a non-plotting backend if needed. But this caused PlantCV imports to switch matplotlib to the agg backend unintentionally, which breaks the plotting debug mode. This PR removes the unneeded matplotlib backend code from the learn submodule.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 17, 2024
Copy link

deepsource-io bot commented Apr 17, 2024

Here's the code health analysis summary for commits a745b53..e2faaf5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren merged commit c858f62 into main Apr 17, 2024
@nfahlgren nfahlgren deleted the fix-debug-plotting branch April 17, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant