Skip to content

Removing list comprehension to allow for short circuit evaluation #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2024
Merged

Removing list comprehension to allow for short circuit evaluation #1494

merged 4 commits into from
Apr 20, 2024

Conversation

natejly
Copy link
Collaborator

@natejly natejly commented Apr 14, 2024

Describe your changes
Removing list comprehension to allow for short-circuit evaluation

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Apr 14, 2024 •
edited
Loading

Here's the code health analysis summary for commits 7e0a54f..bd373f3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 8 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren merged commit 314303c into main Apr 20, 2024
@nfahlgren nfahlgren added the cleanup Code quality updates label Apr 20, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 20, 2024
@nfahlgren nfahlgren deleted the deepsource_PTC-W0016 branch April 20, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfahlgren nfahlgren nfahlgren approved these changes

Assignees
No one assigned
Labels
cleanup Code quality updates
Projects
PlantCV4
Status: Pull Requests
Milestone
PlantCV v4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@natejly @nfahlgren