Skip to content

Fixed uninformative assert statements in tests for transform.merge_images() #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 22, 2024
Merged

Fixed uninformative assert statements in tests for transform.merge_images() #1480

merged 11 commits into from
Mar 22, 2024

Conversation

k034b363
Copy link
Contributor

Describe your changes
Realized that the assert statements in the tests for merge_images were uninformative (see issue #1479 for more details). This PR just changes those statements so that they are actually testing equality of two images, rather than existence of two images.

Type of update
Is this a:

  • Bug fix - kind of

Associated issues
This closes issue #1479

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 linked an issue Mar 21, 2024 that may be closed by this pull request
Problem with transform.merge_images tests #1479
Closed
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Mar 21, 2024 •
edited
Loading

Here's the code health analysis summary for commits cc1e872..7df7e2e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage94.1% (up 0.1% from main)94.1% (up 0.1% from main)
Line Coverage94.1% (up 0.1% from main)94.1% (up 0.1% from main)
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added bugfix Bug fixes work in progress Mark work in progress labels Mar 21, 2024
@k034b363 k034b363 added ready to review and removed work in progress Mark work in progress labels Mar 21, 2024
@nfahlgren nfahlgren merged commit 3964d6a into main Mar 22, 2024
@nfahlgren nfahlgren deleted the 1479-problem-with-transformmerge_images-tests branch March 22, 2024 13:56
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaleySchuhl HaleySchuhl HaleySchuhl approved these changes

Assignees
No one assigned
Labels
bugfix Bug fixes ready to review
Projects
PlantCV4
Status: Pull Requests
Milestone
PlantCV v4.3
Development

Successfully merging this pull request may close these issues.

Problem with transform.merge_images tests
3 participants
@k034b363 @HaleySchuhl @nfahlgren