Skip to content

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Apr 10, 2024

Describe your changes
update _draw_roi method to add order number to debug image whenever there are multiple ROIs

Type of update
Is this a:

  • New feature or feature enhancement
  • Work in progress

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added work in progress Mark work in progress update Updates an existing feature/method labels Apr 10, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.3 milestone Apr 10, 2024
@HaleySchuhl HaleySchuhl self-assigned this Apr 10, 2024
Copy link

deepsource-io bot commented Apr 10, 2024

Here's the code health analysis summary for commits e1eb6d8..96da115. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl
Copy link
Contributor Author

Not really sure how these changes impact the results from pcv.closing but can dig into this next week.

@HaleySchuhl HaleySchuhl removed the work in progress Mark work in progress label Apr 15, 2024
@HaleySchuhl HaleySchuhl requested a review from dhiraj-ms April 18, 2024 14:09
@HaleySchuhl HaleySchuhl added work in progress Mark work in progress and removed ready to review labels Apr 23, 2024
@HaleySchuhl HaleySchuhl removed the work in progress Mark work in progress label Apr 23, 2024
fix rectangle only plotting vertices by adding brackets and undoing the syntax edit in custom so not doubling up
@nfahlgren nfahlgren dismissed dhiraj-ms’s stale review April 23, 2024 21:03

Issues have been fixed

@nfahlgren nfahlgren removed the request for review from dhiraj-ms April 23, 2024 21:04
@nfahlgren nfahlgren merged commit 47e5835 into main Apr 23, 2024
@nfahlgren nfahlgren deleted the rois_debug_numbering branch April 23, 2024 21:06
@HaleySchuhl HaleySchuhl mentioned this pull request May 2, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Order Number to ROI debug images
4 participants