Skip to content

Conversation

natejly
Copy link
Collaborator

@natejly natejly commented Mar 4, 2024

Describe your changes
Fixed failing unit test by casting a list on dictionary keys to make them a sequence

Type of update

  • Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Mar 4, 2024

Here's the code health analysis summary for commits de92513..b2d3bb3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Timed outTimed out: Analysis couldn't finish in timeView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Mar 5, 2024
@nfahlgren nfahlgren merged commit b1764f3 into main Mar 5, 2024
@nfahlgren nfahlgren deleted the fix_sample_images_unit_test branch March 5, 2024 23:58
@nfahlgren
Copy link
Member

@all-contributors please add @natejly for code

Copy link
Contributor

@nfahlgren

I've put up a pull request to add @natejly! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants