Skip to content

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Feb 29, 2024

Describe your changes
DeepSource code coverage is not running on new PRs because it cannot find the DEEPSOURCE_DSN environmental variable even though it has been set in GitHub Secrets, so this PR tries to also add an environmental variable to set it in two places.

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Should not have to do this as documented but here we are
@nfahlgren nfahlgren added the bugfix Bug fixes label Feb 29, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Feb 29, 2024
@nfahlgren nfahlgren merged commit 15161be into main Feb 29, 2024
@nfahlgren nfahlgren deleted the update-deepsource-dsn branch February 29, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants