visualize.colorspaces.py bugfix #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fix to add padding when image widths unequal
remove print statement and 3 images to stack-->leave as list
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 158 158
Lines 6975 6983 +8
=======================================
+ Hits 6974 6982 +8
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
deepsource fixes like whitespace and rename l to sub_imgs
deepsource line too long
|
Noah is busy this afternoon so @k034b363 could you review this PR? Specific dimensions, example below, of images was causing unequal width dimensions but the bugfix pads the smaller image(s) so they can get concatenated. |
annacasto
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix to add padding when image widths unequal
Describe your changes
A clear and concise description of what changes are made by this pull request.
What was the previous functionality (if relevant) and what can we do now with
these changes.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md