You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe your changes
Updated segment_sort to utilize params.sample_label when accessing output observations for trimming the tips to remove the stem. The KeyError was caused by the call to find_tips within segment_sort with no label parameter. find_tips therefore uses the params.sample_label to record the observations and thus if it is not "default", segment_sort fails.
segment_sort seems to be the only morphology function to access outputs.observations in this way; segment_curvature uses a literal key 'backend' to store segment_euclidean_length and segment_path_length observations before calculating curvature, but accesses find_tips output by return image and applying _cv2_findcontours, similarly to other functions.
All modified and coverable lines are covered by tests ✅
Project coverage is 99.98%. Comparing base (a5ede9b) to head (4bb9425).
Report is 51 commits behind head on main.
❗ Current head 4bb9425 differs from pull request most recent head 93db8d8. Consider uploading reports for the commit 93db8d8 to get more accurate results
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updated segment_sort to utilize params.sample_label when accessing output observations for trimming the tips to remove the stem. The KeyError was caused by the call to find_tips within segment_sort with no label parameter. find_tips therefore uses the params.sample_label to record the observations and thus if it is not "default", segment_sort fails.
segment_sort seems to be the only morphology function to access outputs.observations in this way; segment_curvature uses a literal key 'backend' to store segment_euclidean_length and segment_path_length observations before calculating curvature, but accesses find_tips output by return image and applying _cv2_findcontours, similarly to other functions.
Type of update
Associated issues
#1427
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md