Randomize color order default for pcv.watershed() #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 158 158
Lines 6970 6973 +3
===========================================
+ Hits 6970 6972 +2
- Misses 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HaleySchuhl
approved these changes
Feb 2, 2024
|
Thanks @tj-schultz for tackling this open issue with this update. Looks great, so I just approved this PR. |
|
@all-contributors please add @tj-schultz for code |
|
I've put up a pull request to add @tj-schultz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changed default params.color_sequence behavior for watershed. Color_sequence default is now random and restored alongside params.debug.
Type of update
Associated issues
#1428
Additional context
Unsure if further implementation required.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md