Skip to content

Conversation

kaitlynrying
Copy link
Collaborator

@kaitlynrying kaitlynrying commented Feb 5, 2024

Describe your changes
Changed list() generator to list comprehension in line 218

Type of update

  • Bug fix
  • Work in progress

Associated issues
Addresses unnecessary generator from issue PTC-W0015

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@nfahlgren nfahlgren added the cleanup Code quality updates label Apr 21, 2024
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 21, 2024
Copy link

deepsource-io bot commented Apr 21, 2024

Here's the code health analysis summary for commits 314303c..8044660. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ Success
🎯 1 occurence resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren
Copy link
Member

@all-contributors please add @kaitlynrying for code

Copy link
Contributor

@nfahlgren

I've put up a pull request to add @kaitlynrying! 🎉

Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaitlynrying!

@nfahlgren nfahlgren merged commit 1f50633 into danforthcenter:main Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants