1436 merging function #1446
Merged
1436 merging function #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 158 159 +1
Lines 6983 7048 +65
=======================================
+ Hits 6982 7047 +65
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nfahlgren
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added a function called merge_images() that takes as input a directory of images that can be merged in a series to produce one overlapping image. The images must overlap by a known (or guessed) percent, which could be decided through debugging. The function includes the option to merge images vertically or horizontally and 4 methods for handling the overlap region (stacked one on top of each other in series, randomly deciding which to go on top at each overlap, averaging pixels across each overlap region, or a weighted average that results in a gradual transition between images). Changes also include adding documentation and tests for this function.
Type of update
Associated issues
Issue #1436 but does not close it in case other contributors have ideas for improvement of this method.
Additional context
Another function to be added in the future will instead try to stitch images together based on feature landmarks.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md