Skip to content

Conversation

k034b363
Copy link
Contributor

Describe your changes
Deepsource suggests that formatted string literals (or f-strings) are preferred over other string formatting methods. It identified 56 occurrences of strings that were otherwise formatted that could be converted to f-strings. This pull attempts to fix 54 of these, skipping 2 which have more complex interpretations and could be addressed later.

Type of update
Is this a:
Deepsource fix

Associated issues
N/A

Additional context
N/A

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 added the work in progress Mark work in progress label Jan 25, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecdfbf4) 99.98% compared to head (ad6a72c) 99.98%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1439   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         158      158           
  Lines        6975     6975           
=======================================
  Hits         6974     6974           
  Misses          1        1           
Flag Coverage Δ
unittests 99.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plantcv/learn/cli.py 100.00% <100.00%> (ø)
plantcv/plantcv/io/read_dataset.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/segment_angle.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/segment_combine.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/segment_curvature.py 100.00% <100.00%> (ø)
...tcv/plantcv/morphology/segment_euclidean_length.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/segment_id.py 100.00% <100.00%> (ø)
...ntcv/plantcv/morphology/segment_insertion_angle.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/segment_path_length.py 100.00% <100.00%> (ø)
...lantcv/plantcv/morphology/segment_tangent_angle.py 100.00% <100.00%> (ø)
... and 6 more

@k034b363 k034b363 added ready to review cleanup Code quality updates and removed work in progress Mark work in progress labels Jan 26, 2024
@nfahlgren nfahlgren merged commit b072306 into main Feb 3, 2024
@nfahlgren nfahlgren deleted the fix-PYL-C0209 branch February 3, 2024 02:23
@nfahlgren nfahlgren added this to the PlantCV v4.3 milestone Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates ready to review
Projects
Status: Pull Requests
Development

Successfully merging this pull request may close these issues.

2 participants