Correct camera distortions using checkerboard calibration #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1422 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 159 160 +1
Lines 7048 7094 +46
=======================================
+ Hits 7047 7093 +46
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Added a test notebook and test data to the shared Google drive. The folder is called camera_distortions_1422. |
…thub.com/danforthcenter/plantcv into 1416-fisheye-image-distortion-correction
…thub.com/danforthcenter/plantcv into 1416-fisheye-image-distortion-correction
k034b363
approved these changes
Feb 14, 2024
link to source code, link to other documentation page while referencing the downstream step to this one
add link to other doc page while referencing
HaleySchuhl
approved these changes
Feb 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1422 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 161 160 -1
Lines 7066 7094 +28
=======================================
+ Hits 7065 7093 +28
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added the new function checkerboard_calib that takes images of checkerboards and creates correction matrices.
Added the new function calibrate_camera that takes the output correction matrices from checkerboard_calib and corrects camera distortions like fish eye distortions.
Type of update
Is this a:
Associated issues
Issue #1416
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md