-
Notifications
You must be signed in to change notification settings - Fork 271
Closed
Labels
cleanupCode quality updatesCode quality updatesupdateUpdates an existing feature/methodUpdates an existing feature/method
Milestone
Description
Describe the bug
Skeleton tips are easily overwritten within the plantcv morphology sub-package since utilizing tips happens in a few other functions as part of the algorithm for sorting or pruning back segments.
To Reproduce
Steps to reproduce the behavior (including sample data and code really help):
- Starting with image from the morphology tutorial
- Run function(s)
pcv.morphology.find_tips
withlabel=None
and then runpcv.morphology.segment_sort
orpcv.morphology.prune
- See error (small green are expected tips, large green are the recorded tip coordinates)
Expected behavior
Only save tip coordinates when the function is explicitly ran/
Local environment (please complete the following information):
- PlantCV Version : <= 4.6.0
Additional context
Making a helper function to be able to call within functions and now pcv.morphology.find_tips
will be a function that saves to Outputs.observations
and is a wrapper of pcv.morphology._find_tips
.
Metadata
Metadata
Assignees
Labels
cleanupCode quality updatesCode quality updatesupdateUpdates an existing feature/methodUpdates an existing feature/method
Type
Projects
Status
Done