Add 'bind' keyword argument #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neral code style/format)
The key/event bindings to pass to 'fzf'.
Dictionary of the form {KEY: ACTION} or {EVENT: ACTION}.
Corresponds to `--bind=KEYBINDS` fzf option.
dahlia
requested changes
May 7, 2024
dahlia
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key/event bindings to pass to 'fzf'.
Dictionary of the form {KEY: ACTION} or {EVENT: ACTION}.
Corresponds to
--bind=KEYBINDSoption.example:
Related Issue #21
Notes:
Pull-Request includes a minor fix: 'Annotate 'case_sensitive' as Optional explicitly (according to the general code style/format)'. Please provide guidance on including minor fixes or not.
The keyword argument 'bind' was placed according to fzf's manual 'categories' under 'Interface'.
A 'bind' kwarg text snippet has been inserted in the README file. Uncertainty existed regarding the preferred writing style and whether it was appropriate to update the 'Changelog' section.
Sub-Notes:
It is inferred by code comments that the fzf manual 'categories' are the desired grouping/sorting of the kwargs. If the hypothesis is true,
iterfzf()keyword arguments and their listing in README should be rearranged and match.