fix: Don’t prematurely assume properties of “this” in constructors #5876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
I've tested the test that reproduces the soundness issue, and the expect file demonstrates that this PR fixes the soundness issue. The where clause was indeed responsible for setting a constraint too early on the return variable, and removing it and putting it as an assumption in the "new;" seems the right thing to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a soundness issue where, previously, type properties of
thiswere assumed already in the first phase ofconstructors. Now they are assumed at the time of thenew;.Fixes #5136
Description
The details of the fix are as described in issue #5136.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.