fix: Fix parsing error and a crash with non-reference-trait base type #4956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
previously approved these changes
Jan 9, 2024
This reverts commit 6fd41c7.
…e in new resolver
f7746f7
ssomayyajula
previously approved these changes
Jan 11, 2024
ssomayyajula
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three bugs.
One bug was that the new resolver didn't check that the base type of a subset type was determined.
Another bug was that, even after reporting the error in the first bug, the resolver could crash downstream.
The third bug was that, even with a properly formed
x: BaseType, the verifier would crash when trying to construct a default witness (if the base type is a non-reference trait and there is no explicitwitnessclause).Fixes #4946
Note: I previously (and erroneously) thought the bug was a problem in the parser. But we do allow the syntax with just one identifier before the
|in a subset-type declaration. The problem was that the new resolver didn't check to see that the type of that identifier was properly inferred.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.