fix: Kubernetes provider's reconciliation loop decoupled from the startup timeout #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing deprecated functions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release #2447 +/- ##
===========================================
+ Coverage 90.62% 90.65% +0.03%
===========================================
Files 280 280
Lines 12346 12351 +5
===========================================
+ Hits 11188 11197 +9
+ Misses 913 909 -4
Partials 245 245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
This was referenced May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #2444
Checklist
Description
This PR fixes a bug in the implementation of the kubernetes provider that caused its reconciliation loop to exit exactly 15 seconds after heimdall startup.
The issue was due to the reconciliation loop being incorrectly tied to the startup context provided by the dependency injection framework used by heimdall (
uber/fx). This context includes a default timeout of 15 seconds, after which it gets cancelled - even if startup completed successfully.As a result, the reconciliation loop was terminated prematurely, preventing any rule set updates after that point.
The given fix decouples the reconciliation loop from the DI startup context.