Skip to content

Feature ext-cmdline #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 3, 2017
Merged

Feature ext-cmdline #48

merged 15 commits into from
Jul 3, 2017

Conversation

dzhou121
Copy link
Owner

@dzhou121 dzhou121 commented Jul 3, 2017

No description provided.

@dzhou121 dzhou121 merged commit cba647d into master Jul 3, 2017
@dzhou121 dzhou121 deleted the feature/ext-cmdline branch July 3, 2017 06:22
@Shougo
Copy link

Shougo commented Jul 3, 2017

This version binary will be released?

@dzhou121
Copy link
Owner Author

dzhou121 commented Jul 3, 2017

Yes, I'll release the binary under nightly. But you wouldn't actually see the external cmdline until neovim/neovim#6162 is merged. I've made the externalised items dynamic so it can detect if your nvim binary supports the externalised item.

@Shougo Shougo mentioned this pull request Jul 3, 2017
Closed
@Shougo
Copy link

Shougo commented Jul 3, 2017

OK.

@Shougo
Copy link

Shougo commented Jul 3, 2017 

Unhandle event mode_info_set
panic: runtime error: index out of range

goroutine 1 [running, locked to thread]:
github.com/dzhou121/gonvim.(*Screen).put(0xc420138140, 0xc4202a8010, 0x44, 0x44)
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/screen.go:468 +0x40d
github.com/dzhou121/gonvim.(*Editor).handleRedraw(0xc4201c65a0, 0xc4200f0800, 0x4b, 0x4b)
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/editor.go:147 +0x347
github.com/dzhou121/gonvim.InitEditorNew.func1()
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/editor.go:389 +0x97
github.com/dzhou121/gonvim.callbackeditorSignal_RedrawSignal(0x2b9bd90)
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/moc.go:71 +0xb6
github.com/dzhou121/gonvim._cgoexpwrap_858f874cb8aa_callbackeditorSignal_RedrawSignal(0x2b9bd90)
        github.com/dzhou121/gonvim/_obj/_cgo_gotypes.go:769 +0x2b
github.com/dzhou121/gonvim._Cfunc_editorSignal_EventDefault(0x2b9bd90, 0x7f1350000aa0, 0x0)
        github.com/dzhou121/gonvim/_obj/_cgo_gotypes.go:347 +0x4a
github.com/dzhou121/gonvim.(*editorSignal).EventDefault.func1(0x2b9bd90, 0x7f1350000aa0, 0x7f1350000aa0)
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/moc.go:532 +0xa3
github.com/dzhou121/gonvim.(*editorSignal).EventDefault(0xc42031a000, 0xf5c980, 0xc420316168, 0x5)
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/moc.go:532 +0x74
github.com/dzhou121/gonvim.callbackeditorSignal_Event(0x2b9bd90, 0x7f1350000aa0, 0xc400000008)
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/moc.go:527 +0x1c0
github.com/dzhou121/gonvim._cgoexpwrap_858f874cb8aa_callbackeditorSignal_Event(0x2b9bd90, 0x7f1350000aa0, 0x2ab5401)
        github.com/dzhou121/gonvim/_obj/_cgo_gotypes.go:860 +0x35
github.com/therecipe/qt/widgets._Cfunc_QApplication_QApplication_Exec(0x0)
        github.com/therecipe/qt/widgets/_obj/_cgo_gotypes.go:894 +0x49
github.com/therecipe/qt/widgets.QApplication_Exec(0xc4201cd2b0)
        /home/user/work/src/github.com/therecipe/qt/widgets/widgets-minimal.go:881 +0x22
github.com/dzhou121/gonvim.InitEditorNew()
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/editor.go:475 +0x1575
main.main()
        /media/sf_GOPATH0/src/github.com/dzhou121/gonvim/cmd/gonvim/gonvim.go:15 +0x3a

The errors are occurred.

@dzhou121
Copy link
Owner Author

dzhou121 commented Jul 3, 2017

I seem not to be able to replicate.

@Shougo
Copy link

Shougo commented Jul 3, 2017

gonvim -u NONE works.

@Shougo
Copy link

Shougo commented Jul 3, 2017

I have analayzed the problem.
dein.vim is broken in gonvim.

@dzhou121
Copy link
Owner Author

dzhou121 commented Jul 3, 2017

Just updated nightly. Can you please try again.

@Shougo
Copy link

Shougo commented Jul 3, 2017

It works. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzhou121 @Shougo