Skip to content

Conversation

esmane
Copy link
Contributor

@esmane esmane commented Oct 21, 2023

I have no idea how any of this github stuff works so if I did something incorrectly let me know. My effect simulates film gate weave by sort of randomly moving the frame around every frame.

@jaromil
Copy link
Member

jaromil commented Dec 8, 2023

Hey mate welcome!! appreciate your contribution, PR looks fine and code smells wise :^) haven't tried it yet myself so please be patient a little while more, will run the filters through some tests and hopefully merge this. No further action needed on your side, unless you have more fixes to your code. Cheers!

@esmane
Copy link
Contributor Author

esmane commented Dec 8, 2023

Hey mate welcome!! appreciate your contribution, PR looks fine and code smells wise :^) haven't tried it yet myself so please be patient a little while more, will run the filters through some tests and hopefully merge this. No further action needed on your side, unless you have more fixes to your code. Cheers!

No problems waiting! I think I'm pretty happy with the way my effects work and look at least for now. I'm not sure if it matters but my video editor of choice is Kdenlive and as such that's what I've been testing it with. I downloaded Shotcut just to see but no luck getting them to appear in the editor. Thanks again!

Copy link
Member

@jaromil jaromil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@jaromil jaromil merged commit fdc9f32 into dyne:master Apr 10, 2024
@esmane
Copy link
Contributor Author

esmane commented Apr 11, 2024

Thank you! now I need to make my effects thread safe haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants